Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup nil pointer introduced in 9127ccee42ebb4f2f7dd09c707583c53464f134c #3260

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

thomshutt
Copy link
Contributor

The value I was using isn't populated yet, so I switched to grabbing it from the config instead

@github-actions github-actions bot added the go Pull requests that update Go code label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 34.65153%. Comparing base (c97f783) to head (c7fcc34).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/livepeer/starter/starter.go 0.00000% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3260         +/-   ##
===================================================
- Coverage   34.65259%   34.65153%   -0.00106%     
===================================================
  Files            136         136                 
  Lines          36283       36287          +4     
===================================================
+ Hits           12573       12574          +1     
- Misses         22997       23000          +3     
  Partials         713         713                 
Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.65795% <0.00000%> (-0.01959%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c97f783...c7fcc34. Read the comment docs.

Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.65795% <0.00000%> (-0.01959%) ⬇️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@thomshutt thomshutt merged commit 47d55b9 into master Nov 19, 2024
19 of 20 checks passed
@thomshutt thomshutt deleted the fix-nil branch November 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants